On Thu, Jul 16, 2015 at 12:22:40PM -0500, Tom Zanussi wrote:
> +     for (i = 0; i < elt->map->n_fields; i++) {
> +             atomic64_set(&dup_elt->fields[i].sum,
> +                          atomic64_read(&elt->fields[i].sum));
> +             dup_elt->fields[i].cmp_fn = elt->fields[i].cmp_fn;
> +     }
> +
> +     return dup_elt;
> +}

So there is a lot of atomic64_{set,read}() in this patch set, what kind
of magic properties do you assume they have?

Note that atomic*_{set,read}() are weaker than {WRITE,READ}_ONCE(), so
if you're assuming they do that, you're mistaken -- although it is on a
TODO list someplace to go fix that.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to