On Friday 17 July 2015 02:02 AM, Mark Brown wrote:
On Thu, Jul 16, 2015 at 11:46:58PM +0530, Vaibhav Hiremath wrote:
.disable = regulator_disable_regmap,
.is_enabled = regulator_is_enabled_regmap,
.get_current_limit = pm800_get_current_limit,
+ .set_current_limit = pm800_set_current_limit,
set_current_limit() isn't the right interface to use for this, this is
something that depends on the physical design of the system rather than
something that limits the current. It should be a DT property of its
own. There are some other PMICs with similar functions but it's not
clear yet how generic the configuration mechanism is.
Hmmm,
Yeah, right. This is depends on physical design. And not the regulator
current limit.
Earlier, I had submitted DT based approach, but was MFD DT property.
Which is not correct, do you think regulator DT property is the right
approach?
Below is going to be my approach -
pmic1: 88pm860@30 {
compatible = "marvell,88pm800";
...
regulators {
compatible = "marvell,88pm80x-regulator";
marvell,88pm860-buck1-dualphase-en;
buck1: buck1 {
...
};
...
};
};
Thanks,
Vaibhav
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
