On 07/18, Dave Chinner wrote: > > On Fri, Jul 17, 2015 at 07:31:17PM +0200, Oleg Nesterov wrote: > > > > Dave, I didn't write this comment. Please look at acquire_freeze_lock(). > > If we can remove this logic - great! but this needs a separate change. > > Oh, I think I know what it was - when we duplicate a transaction for > a rolling commit, we do it before committing the current transaction > is committed. I *think* that used to take a second freeze reference, > which only existed until the first transaction was committed. We do > things a bit differently now - we hold a state flag on the > transaction to indicate it needs to release the freeze reference > when it is freed and we pass it to the new transaction so that the > first transaction commit doesn't release it.
Just fyi, please do not assume I can understand the explanation above ;) > So, yes, it may well be a stale comment now. Perhaps. But this needs a separate change. Plus even if we remove this hack, this code has other problems with lockdep. I'll send the "lockdep" fixes/cleanup today, please review. Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
