* Andy Lutomirski <[email protected]> wrote:
> On Mon, Jul 20, 2015 at 11:28 PM, Ingo Molnar <[email protected]> wrote:
> >
> > * Brian Gerst <[email protected]> wrote:
> >
> >> Allocate a separate structure for the vm86 fields.
> >
> > Why is this allocated dynamically? This structure is not very large, and a
> > hole in thread_struct isn't that big of an issue - compared to additional
> > fragility introduced by the (mostly untested by normal apps) dynamic
> > allocation here ...
> >
> > I don't mind the introduction of the sub-structure in itself, but please
> > embedd it in thread_struct.
>
> This ends up being several hundred bytes, I think, due to including an entire
> struct pt_regs. Do we really want to enlarge thread_struct that much for
> something that's essentially never used?
Ok, I only judged by the first patch, I did not realize it becomes that much
larger in later patches.
I've extended the changelog to explain this properly.
Thanks,
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
