El 09/07/15 a les 22.42, Julien Grall ha escrit: > Currently, blkif_queue_request has 2 distinct execution path: > - Send a discard request > - Send a read/write request > > The function is also allocating grants to use for generating the > request. Although, this is only used for read/write request. > > Rather than having a function with 2 distinct execution path, separate > the function in 2. This will also remove one level of tabulation. > > Signed-off-by: Julien Grall <[email protected]> > Cc: Konrad Rzeszutek Wilk <[email protected]> > Cc: Roger Pau Monné <[email protected]> > Cc: Boris Ostrovsky <[email protected]> > Cc: David Vrabel <[email protected]>
Patch looks fine, although with so much indentation changes it's kind of hard to review. Acked-by: Roger Pau Monné <[email protected]> Just one minor change below. [...] > @@ -595,6 +603,24 @@ static int blkif_queue_request(struct request *req) > return 0; > } > > +/* > + * Generate a Xen blkfront IO request from a blk layer request. Reads > + * and writes are handled as expected. > + * > + * @req: a request struct > + */ > +static int blkif_queue_request(struct request *req) > +{ > + struct blkfront_info *info = req->rq_disk->private_data; > + > + if (unlikely(info->connected != BLKIF_STATE_CONNECTED)) > + return 1; > + > + if (unlikely(req->cmd_flags & (REQ_DISCARD | REQ_SECURE))) > + return blkif_queue_discard_req(req); > + else > + return blkif_queue_rw_req(req); There's no need for the else clause. Roger. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
