Hi,

> +/dts-v1/;
> +
> +/memreserve/ 0x00000000 0x01000000;

What's this reservation for?

Given you're using PSCI I can't see why we'd expect the kernel to map
but not use some memory.

> +
> +#include "berlin4ct.dtsi"
> +
> +/ {
> +     model = "MARVELL BG4CT DMP BOARD";
> +     compatible = "marvell,berlin4ct-dmp", "marvell,berlin4ct", 
> "marvell,berlin";
> +
> +     chosen {
> +             bootargs = "earlyprintk";
> +             stdout-path = "serial0:115200n8";
> +     };

You shouldn't need those bootargs; "earlyprintk" does nothing on arm64.

[...]

> +             gic: interrupt-controller@901000 {
> +                     compatible = "arm,gic-400";
> +                     #interrupt-cells = <3>;
> +                     interrupt-controller;
> +                     reg = <0x901000 0x1000>,
> +                           <0x902000 0x1000>,
> +                           <0x904000 0x2000>,
> +                           <0x906000 0x2000>;
> +                     interrupts = <GIC_PPI 9 (GIC_CPU_MASK_SIMPLE(4) | 
> IRQ_TYPE_LEVEL_HIGH)>;
> +             };
> +

I believe the size of the cpu interface (the second reg entry) should be
0x2000, as GICC_DIR is at offset 0x1000.

Otherwise this looks fine.

Thanks,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to