On Fri, 2005-08-26 at 17:44 -0500, Dmitry Torokhov wrote:
> Is this function used in a hot path to warrant using "unlikely"? There
> are to many "unlikely" in the code for my taste.
unlikely() can result in better, smaller, faster code. and it acts as a
nice directive to programmers reading the code.
> input_[un]register_device and del_timer_sync are "long" operations. I
> think a semaphore would be better here.
I was considering moving all locking to a single semaphore, actually.
Robert Love
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
