On Wed, 22 Jul 2015, Pavel Machek wrote: > > I am however not sure whether input_leds_connect() is not too unkind to > > unnamed LEDs and shouldn't be more tolerant to those in the long term. > > Maybe. > > > From: Jiri Kosina <jkos...@suse.com> > > Subject: [PATCH] Input: leds: don't attempt to deregister unnamed LEDs > > > > input_leds_connect() is skipping registration of LEDs for which > > there is no symbolic name in input_led_info[]. > > Yes, and rather than testing for "no name" special case at two places, > what about simply giving up when we see such error?
Well, that's quite the oposite of the "be more tolerant" aproach proposed above :) I don't see a reason why the sole fact that the device has at least one LED that kernel can't handle properly should mean that neither of the other LEDs will work. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
