On Thu, Jul 23, 2015 at 8:56 AM, Steven Rostedt <rost...@goodmis.org> wrote: > On Thu, 23 Jul 2015 08:31:39 -0700 > Andy Lutomirski <l...@kernel.org> wrote: > >> Switch from wrmsr to wrmsrl_safe to prepare to merge the 32-bit and >> 64-bit code, and use __KERNEL_CS explicitly to initialize >> MSR_IA32_SYSENTER_CS. While we're at it, tweak the whitespace a >> bit. > > Saying "prepare to merge the 32-bit and 64-bit" isn't that informative > to why this patch is needed. Can you please describe in the change log > what can fault with the wrmsr call, when we do the merge?
Oh... Nothing can fault in the wrmsr as far as I know, but maybe there's a CPU out there that advertises SEP but doesn't have the MSRs. Ingo, Thomas, want a v2 that explains that the wrmsr_safe is there for consistency but that I don't know why 32bit does it? Another option would be to remove the _safe from the 32-bit version. --Andy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
