Now when we have generic kasan_populate_zero_shadow() we could
use it for x86.

Signed-off-by: Andrey Ryabinin <[email protected]>
---
 arch/x86/mm/kasan_init_64.c | 109 ++------------------------------------------
 1 file changed, 5 insertions(+), 104 deletions(-)

diff --git a/arch/x86/mm/kasan_init_64.c b/arch/x86/mm/kasan_init_64.c
index 812086c..9ce5da2 100644
--- a/arch/x86/mm/kasan_init_64.c
+++ b/arch/x86/mm/kasan_init_64.c
@@ -48,106 +48,6 @@ static void __init kasan_map_early_shadow(pgd_t *pgd)
        }
 }
 
-static int __init zero_pte_populate(pmd_t *pmd, unsigned long addr,
-                               unsigned long end)
-{
-       pte_t *pte = pte_offset_kernel(pmd, addr);
-
-       while (addr + PAGE_SIZE <= end) {
-               WARN_ON(!pte_none(*pte));
-               set_pte(pte, __pte(__pa_nodebug(kasan_zero_page)
-                                       | __PAGE_KERNEL_RO));
-               addr += PAGE_SIZE;
-               pte = pte_offset_kernel(pmd, addr);
-       }
-       return 0;
-}
-
-static int __init zero_pmd_populate(pud_t *pud, unsigned long addr,
-                               unsigned long end)
-{
-       int ret = 0;
-       pmd_t *pmd = pmd_offset(pud, addr);
-
-       while (IS_ALIGNED(addr, PMD_SIZE) && addr + PMD_SIZE <= end) {
-               WARN_ON(!pmd_none(*pmd));
-               set_pmd(pmd, __pmd(__pa_nodebug(kasan_zero_pte)
-                                       | _KERNPG_TABLE));
-               addr += PMD_SIZE;
-               pmd = pmd_offset(pud, addr);
-       }
-       if (addr < end) {
-               if (pmd_none(*pmd)) {
-                       void *p = vmemmap_alloc_block(PAGE_SIZE, NUMA_NO_NODE);
-                       if (!p)
-                               return -ENOMEM;
-                       set_pmd(pmd, __pmd(__pa_nodebug(p) | _KERNPG_TABLE));
-               }
-               ret = zero_pte_populate(pmd, addr, end);
-       }
-       return ret;
-}
-
-
-static int __init zero_pud_populate(pgd_t *pgd, unsigned long addr,
-                               unsigned long end)
-{
-       int ret = 0;
-       pud_t *pud = pud_offset(pgd, addr);
-
-       while (IS_ALIGNED(addr, PUD_SIZE) && addr + PUD_SIZE <= end) {
-               WARN_ON(!pud_none(*pud));
-               set_pud(pud, __pud(__pa_nodebug(kasan_zero_pmd)
-                                       | _KERNPG_TABLE));
-               addr += PUD_SIZE;
-               pud = pud_offset(pgd, addr);
-       }
-
-       if (addr < end) {
-               if (pud_none(*pud)) {
-                       void *p = vmemmap_alloc_block(PAGE_SIZE, NUMA_NO_NODE);
-                       if (!p)
-                               return -ENOMEM;
-                       set_pud(pud, __pud(__pa_nodebug(p) | _KERNPG_TABLE));
-               }
-               ret = zero_pmd_populate(pud, addr, end);
-       }
-       return ret;
-}
-
-static int __init zero_pgd_populate(unsigned long addr, unsigned long end)
-{
-       int ret = 0;
-       pgd_t *pgd = pgd_offset_k(addr);
-
-       while (IS_ALIGNED(addr, PGDIR_SIZE) && addr + PGDIR_SIZE <= end) {
-               WARN_ON(!pgd_none(*pgd));
-               set_pgd(pgd, __pgd(__pa_nodebug(kasan_zero_pud)
-                                       | _KERNPG_TABLE));
-               addr += PGDIR_SIZE;
-               pgd = pgd_offset_k(addr);
-       }
-
-       if (addr < end) {
-               if (pgd_none(*pgd)) {
-                       void *p = vmemmap_alloc_block(PAGE_SIZE, NUMA_NO_NODE);
-                       if (!p)
-                               return -ENOMEM;
-                       set_pgd(pgd, __pgd(__pa_nodebug(p) | _KERNPG_TABLE));
-               }
-               ret = zero_pud_populate(pgd, addr, end);
-       }
-       return ret;
-}
-
-
-static void __init populate_zero_shadow(const void *start, const void *end)
-{
-       if (zero_pgd_populate((unsigned long)start, (unsigned long)end))
-               panic("kasan: unable to map zero shadow!");
-}
-
-
 #ifdef CONFIG_KASAN_INLINE
 static int kasan_die_handler(struct notifier_block *self,
                             unsigned long val,
@@ -199,7 +99,7 @@ void __init kasan_init(void)
 
        clear_pgds(KASAN_SHADOW_START, KASAN_SHADOW_END);
 
-       populate_zero_shadow((void *)KASAN_SHADOW_START,
+       kasan_populate_zero_shadow((void *)KASAN_SHADOW_START,
                        kasan_mem_to_shadow((void *)PAGE_OFFSET));
 
        for (i = 0; i < E820_X_MAX; i++) {
@@ -209,14 +109,15 @@ void __init kasan_init(void)
                if (map_range(&pfn_mapped[i]))
                        panic("kasan: unable to allocate shadow!");
        }
-       populate_zero_shadow(kasan_mem_to_shadow((void *)PAGE_OFFSET + MAXMEM),
-                       kasan_mem_to_shadow((void *)__START_KERNEL_map));
+       kasan_populate_zero_shadow(
+               kasan_mem_to_shadow((void *)PAGE_OFFSET + MAXMEM),
+               kasan_mem_to_shadow((void *)__START_KERNEL_map));
 
        vmemmap_populate((unsigned long)kasan_mem_to_shadow(_stext),
                        (unsigned long)kasan_mem_to_shadow(_end),
                        NUMA_NO_NODE);
 
-       populate_zero_shadow(kasan_mem_to_shadow((void *)MODULES_END),
+       kasan_populate_zero_shadow(kasan_mem_to_shadow((void *)MODULES_END),
                        (void *)KASAN_SHADOW_END);
 
        memset(kasan_zero_page, 0, PAGE_SIZE);
-- 
2.4.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to