On Fri, 24 Jul 2015, Christoph Lameter wrote: > On Fri, 24 Jul 2015, Vlastimil Babka wrote: > > > diff --git a/include/linux/gfp.h b/include/linux/gfp.h > > index 531c72d..104a027 100644 > > --- a/include/linux/gfp.h > > +++ b/include/linux/gfp.h > > @@ -321,8 +321,12 @@ static inline struct page *alloc_pages_node(int nid, > > gfp_t gfp_mask, > > unsigned int order) > > { > > /* Unknown node is current (or closest) node */ > > - if (nid == NUMA_NO_NODE) > > + if (nid == NUMA_NO_NODE) { > > nid = numa_mem_id(); > > + } else if (!node_online(nid)) { > > + VM_WARN_ON(!node_online(nid)); > > + nid = numa_mem_id(); > > + } > > I would think you would only want this for debugging purposes. The > overwhelming majority of hardware out there has no memory > onlining/offlining capability after all and this adds the overhead to each > call to alloc_pages_node. > > Make this dependo n CONFIG_VM_DEBUG or some such thing? >
Yeah, the suggestion was for VM_WARN_ON() in the conditional, but the placement has changed somewhat because of the new __alloc_pages_node(). I think else if (VM_WARN_ON(!node_online(nid))) nid = numa_mem_id(); should be fine since it only triggers for CONFIG_DEBUG_VM. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/