Hi Krzysztof Kozlowski, >On Tue, Jun 23, 2015 at 09:58:41AM +0900, Krzysztof Kozlowski wrote: >> 2015-06-08 10:22 GMT+09:00 Krzysztof Kozlowski <k.kozlow...@samsung.com>: >> > 2015-05-24 12:41 GMT+09:00 Ramakrishna Pallala >> > <ramakrishna.pall...@intel.com>: >> >> This patch adds the support for following battery properties to > >> max17042 fuel gauge driver. >> >> >> >> POWER_SUPPLY_PROP_TEMP_ALERT_MIN > >> POWER_SUPPLY_PROP_TEMP_ALERT_MAX >> >> POWER_SUPPLY_PROP_TEMP_MIN >> >> POWER_SUPPLY_PROP_TEMP_MAX >> >> POWER_SUPPLY_PROP_HEALTH >> > >> > I wonder, have you tested the patch? After booting on Trats2 device >> > (max77693 which identifies itself as 17047-like) the values are: >> > POWER_SUPPLY_TEMP_ALERT_MIN=1280 >> > POWER_SUPPLY_TEMP_ALERT_MAX=1270 >> > POWER_SUPPLY_TEMP=257 >> > This is okay, datasheet says that register after booting will have >> > value of 0x7f80. >> > >> > However setting them to some value which should trigger interrupts >> > (like 300 for MIN or 200 for MAX) does not trigger the interrupt. I >> > added a printk in max17042_thread_handler(). >> > >> > Is the temperature alert feature working? >> >> Can you reply to my question above? >> If this feature is not working, then it should be removed.
>What's the status of this? I cannot test the feature, since I don't have the >hardware. I agree, that this should be removed, if it's not working. I missed this email (may be overlooked it). To have the interrupts enabled we need the config registers(0x1Dh) bit's BIT(9), BIT(4) and BIT92) should be 1 and BIT(8) should be 0. Can you dump the status(00h), Talrt(02H) Temp(08h) and config(1Dh) registers values and share? Thanks, Ram -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
