On Mon, Jul 27, 2015 at 12:50:36PM +0200, Peter Zijlstra wrote: > On Mon, Jul 27, 2015 at 12:47:55PM +0200, Peter Zijlstra wrote: > > On Mon, Jul 27, 2015 at 12:20:46PM +0200, Heiko Carstens wrote: > > > On Mon, Jul 27, 2015 at 11:52:25AM +0200, Peter Zijlstra wrote: > > > > > +static __always_inline bool arch_static_branch_jump(struct > > > > > static_key *key, bool branch) > > > > > +{ > > > > > + asm_volatile_goto("0: j %l[l_yes]\n" > > > > > > > > Looking at the s390 version of jump_label_make_branch(), this should > > > > have been: > > > > > > > > "brcl 15, %l[l_yes]\n" > > > > > > > > I suppose? > > > > > > Yes. I wanted to test your version, but I assume you will send > > > an updated version soon? > > > > I just send out updated patches for 5/6. They boot without issue on my > > x86_64. > > Also, it helps if you convert one static_key user into something that'll > trigger this new code. > > The one I picked is unfortunately rather x86 specific.
Yeah, just did that and it crashes ;) Hopefully I'll have time to look into it today. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/