> -----Original Message-----
> From: Shawn Guo [mailto:shawn...@kernel.org]
> Sent: Monday, July 27, 2015 10:13 PM
> To: Chen Haibo-B51421
> Cc: robh...@kernel.org; pawel.m...@arm.com; mark.rutl...@arm.com;
> ijc+devicet...@hellion.org.uk; ga...@codeaurora.org;
> ker...@pengutronix.de; li...@arm.linux.org.uk; dmitry.torok...@gmail.com;
> devicet...@vger.kernel.org; sbran...@broadcom.com; a...@arndb.de;
> mche...@osg.samsung.com; christian.gmei...@gmail.com;
> scott....@emc.com.tw; linux-kernel@vger.kernel.org; hdego...@redhat.com;
> jonat...@broadcom.com; benjamin.tissoi...@redhat.com;
> hans.verk...@cisco.com; had...@hadess.net; linux-in...@vger.kernel.org;
> ge...@linux-m68k.org; sebastien.szyman...@armadeus.com;
> mamli...@gmail.com; linux-arm-ker...@lists.infradead.org
> Subject: Re: [PATCH 5/5] ARM: dts: imx6ul-14x14-evk.dts: add tsc support
> 
> On Mon, Jul 27, 2015 at 07:26:47PM +0800, Haibo Chen wrote:
> > Add touch screen surpport for i.MX6UL-EVK board.
> >
> > Signed-off-by: Haibo Chen <haibo.c...@freescale.com>
> > ---
> >  arch/arm/boot/dts/imx6ul-14x14-evk.dts | 18 ++++++++++++++++++
> >  1 file changed, 18 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/imx6ul-14x14-evk.dts
> b/arch/arm/boot/dts/imx6ul-14x14-evk.dts
> > index 61b41ee..323d32d 100644
> > --- a/arch/arm/boot/dts/imx6ul-14x14-evk.dts
> > +++ b/arch/arm/boot/dts/imx6ul-14x14-evk.dts
> > @@ -44,6 +44,15 @@
> >     soc-supply = <&reg_soc>;
> >  };
> >
> > +&tsc {
> > +   pinctrl-names = "default";
> > +   pinctrl-0 = <&pinctrl_tsc>;
> > +   status = "okay";
> 
> We generally have "status" at the bottom of the property list.
> 
> Shawn
>
 
[haibo] Yes, it's my negligence, I will amend this.

> > +   xnur-gpio = <&gpio1 3 0>;
> > +   measure_delay_time = <0xffff>;
> > +   pre_charge_time = <0xfff>;
> > +};
> > +
> >  &uart1 {
> >     pinctrl-names = "default";
> >     pinctrl-0 = <&pinctrl_uart1>;
> > @@ -212,6 +221,15 @@
> >             >;
> >     };
> >
> > +   pinctrl_tsc: tscgrp {
> > +           fsl,pins = <
> > +                   MX6UL_PAD_GPIO1_IO01__GPIO1_IO01                0xb0
> > +                   MX6UL_PAD_GPIO1_IO02__GPIO1_IO02                0xb0
> > +                   MX6UL_PAD_GPIO1_IO03__GPIO1_IO03                0xb0
> > +                   MX6UL_PAD_GPIO1_IO04__GPIO1_IO04                0xb0
> > +           >;
> > +   };
> > +
> >     pinctrl_uart1: uart1grp {
> >             fsl,pins = <
> >                     MX6UL_PAD_UART1_TX_DATA__UART1_DCE_TX 0x1b0b1
> > --
> > 1.9.1
> >
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-ker...@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> >
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to