When building with a prefix ending with a slash, for example:

        $ make prefix=/usr/local/

one of the perf tests fail to compile due to BUILD_STR macro mishandling
bindir_SQ string containing with two slashes:

        -DBINDIR="BUILD_STR(/usr/local//bin)"

with the following error:

          CC       tests/attr.o
        tests/attr.c: In function ‘test__attr’:
        tests/attr.c:168:50: error: expected ‘)’ before ‘;’ token
          snprintf(path_perf, PATH_MAX, "%s/perf", BINDIR);
                                                  ^
        tests/attr.c:176:1: error: expected ‘;’ before ‘}’ token
         }
         ^
        tests/attr.c:176:1: error: control reaches end of non-void function 
[-Werror=return-type]
         }
         ^
        cc1: all warnings being treated as errors

This patch works around the problem by "cleaning" the bindir string
using make's abspath function.

Signed-off-by: Pawel Moll <pawel.m...@arm.com>
---
 tools/perf/config/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
index b4a9c29..e8d987a 100644
--- a/tools/perf/config/Makefile
+++ b/tools/perf/config/Makefile
@@ -638,7 +638,7 @@ ifndef DESTDIR
 prefix ?= $(HOME)
 endif
 bindir_relative = bin
-bindir = $(prefix)/$(bindir_relative)
+bindir = $(abspath $(prefix)/$(bindir_relative))
 mandir = share/man
 infodir = share/info
 perfexecdir = libexec/perf-core
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to