On ma, 2015-07-27 at 10:44 +0100, Lee Jones wrote:
> --- /dev/null
> +++ b/drivers/mailbox/mailbox-sti.c

> +static int sti_mbox_probe(struct platform_device *pdev)
> +{
> +     [...]
> +
> +     match = of_match_device(sti_mailbox_match, &pdev->dev);
> +     if (!match) {
> +             dev_err(&pdev->dev, "No configuration found\n");
> +             return -ENODEV;
> +     }
> +     pdev->dev.platform_data = (struct sti_mbox_pdata *) match->data;
> +
> +     [...]
> +}

> +static struct platform_driver sti_mbox_driver = {
> +     .probe = sti_mbox_probe,
> +     .remove = sti_mbox_remove,
> +     .driver = {
> +             .name = "sti-mailbox",
> +             .of_match_table = sti_mailbox_match,
> +     },
> +};
> +module_platform_driver(sti_mbox_driver);

> +MODULE_ALIAS("platform:mailbox-sti");

It seems this alias is only useful if there's a corresponding struct
platform_device with a "mailbox-sti" .name. I couldn't spot that
platform_device.

Besides, if I read sti_max_probe() correctly, without OF support loading
this module won't accomplish much. So what would another way of
autoloading this module buy you?

Thanks,


Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to