Sorry, for late reply. > -----Original Message----- > From: Mel Gorman [mailto:mgor...@suse.de] > Sent: Wednesday, July 22, 2015 7:36 PM > To: PINTU KUMAR > Cc: a...@linux-foundation.org; cor...@lwn.net; vba...@suse.cz; > gorcu...@openvz.org; mho...@suse.cz; emun...@akamai.com; > kirill.shute...@linux.intel.com; standby2...@gmail.com; > han...@cmpxchg.org; vdavy...@parallels.com; hu...@google.com; > minc...@kernel.org; t...@kernel.org; rient...@google.com; > xypron.g...@gmx.de; dzic...@redhat.com; pra...@redhat.com; > ebied...@xmission.com; rost...@goodmis.org; uober...@redhat.com; > paul...@linux.vnet.ibm.com; iamjoonsoo....@lge.com; ddstr...@ieee.org; > sasha.le...@oracle.com; koc...@gmail.com; c...@linux.com; > opensource.gan...@gmail.com; vinme...@codeaurora.org; linux- > d...@vger.kernel.org; linux-kernel@vger.kernel.org; linux...@kvack.org; linux- > p...@vger.kernel.org; qiuxi...@huawei.com; valdis.kletni...@vt.edu; > c...@samsung.com; pintu_agar...@yahoo.com; vishnu...@samsung.com; > rohit...@samsung.com; iqbal....@samsung.com; pintu.p...@gmail.com; > pint...@outlook.com > Subject: Re: [PATCH v3 1/1] kernel/sysctl.c: Add /proc/sys/vm/shrink_memory > feature > > On Wed, Jul 22, 2015 at 06:33:26PM +0530, PINTU KUMAR wrote: > > Dear Mel, thank you very much for your comments and suggestions. > > I will drop this one and look on further improving direct_reclaim and > > compaction. > > Just few more comments below before I close. > > > > Also, during this patch, I feel that the hibernation_mode part in > > shrink_all_memory can be corrected. > > So, can I separately submit the below patch? > > That is instead of hard-coding the hibernation_mode, we can get > > hibernation status using: > > system_entering_hibernation() > > > > Please let me know your suggestion about this changes. > > > > -#ifdef CONFIG_HIBERNATION > > +#if defined CONFIG_HIBERNATION || CONFIG_SHRINK_MEMORY > I was talking about only the following case. Instead of hard coding the hibernation_mode in shrink_all_memory, We can set it at runtime.
- .hibernation_mode = 1, + if (system_entering_hibernation()) + sc.hibernation_mode = 1; + else + sc.hibernation_mode = 0; The PM owners should confirm if this is ok. Once confirmed, I will submit the full patch set. +> This appears to be a patch on top of "Add /proc/sys/vm/shrink_memory feature" > so I do not see what would be separately submitted that would make sense. > And we don't need to have /proc/sys/vm/shrink_memory patch for this. However, if required, we can also expose shrink_all_memory() outside the hibernation using the CONFIG_SHRINK_MEMORY. Otherwise, we can neglect other changes. > -- > Mel Gorman > SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
