On 31-07-15, 17:32, yalin wang wrote:
>
> > On Jul 31, 2015, at 16:56, Kirill A. Shutemov <kir...@shutemov.name> wrote:
> >
> > On Fri, Jul 31, 2015 at 02:08:34PM +0530, Viresh Kumar wrote:
> >> IS_ERR(_OR_NULL) already contain an 'unlikely' compiler flag and there
> >> is no need to do that again from its callers. Drop it.
> >>
> >> Signed-off-by: Viresh Kumar <viresh.ku...@linaro.org>
> >
> > Acked-by: Kirill A. Shutemov <kirill.shute...@linux.intel.com>
> search in code, there are lots of using like this , does need add this check
> into checkpatch ?
cc'd Joe for that. :)
> # grep -r 'likely.*IS_ERR' .
> ./include/linux/blk-cgroup.h: if (unlikely(IS_ERR(blkg)))
> ./fs/nfs/objlayout/objio_osd.c: if (unlikely(IS_ERR(od))) {
> ./fs/cifs/readdir.c: if (unlikely(IS_ERR(dentry)))
> ./fs/ext4/extents.c: if (unlikely(IS_ERR(bh))) {
> ./fs/ext4/extents.c: if (unlikely(IS_ERR(path1))) {
> ./fs/ext4/extents.c: if (unlikely(IS_ERR(path2))) {
Btw, my series has fixed all of them :)
--
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
