On 03-08-15, 17:38, Steven Rostedt wrote: > On Fri, 31 Jul 2015 13:23:10 +0300 > "Kirill A. Shutemov" <kir...@shutemov.name> wrote: > > We have two cases in code: > > > > drivers/rtc/rtc-gemini.c: if (likely(IS_ERR(rtc->rtc_dev))) > > drivers/staging/lustre/lustre/obdclass/lu_object.c: if > > (likely(IS_ERR(shadow) && PTR_ERR(shadow) == -ENOENT)) { > > > > The first one is mistake, I think. Or do we expect rtc_device_register() > > to fail? > > > > The second is redundant. "if (PTR_ERR(shadow) == -ENOENT)" should do the > > job. > > > > Yep, those look like bugs to me.
Yeah, I have fixed both of them :) -- viresh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/