Add basic success/failure checking of __copy_to_user_inatomic() and
__copy_from_user_inatomic(). For testing purposes these are similar to
their non-atomic non-checking friends, so the new tests match those for
__copy_to_user() and __copy_from_user().
New tests:
- legitimate __copy_from_user_inatomic
- legitimate __copy_to_user_inatomic
- illegal all-kernel __copy_from_user_inatomic
- illegal reversed __copy_from_user_inatomic
- illegal all-kernel __copy_to_user_inatomic
- illegal reversed __copy_to_user_inatomic
- legitimate all-kernel __copy_from_user_inatomic
- legitimate all-kernel __copy_to_user_inatomic
Signed-off-by: James Hogan <james.ho...@imgtec.com>
Cc: Kees Cook <keesc...@chromium.org>
Cc: Andrew Morton <a...@linux-foundation.org>
---
lib/test_user_copy.c | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/lib/test_user_copy.c b/lib/test_user_copy.c
index 310e796beef6..6cbdb0a15ca2 100644
--- a/lib/test_user_copy.c
+++ b/lib/test_user_copy.c
@@ -79,8 +79,12 @@ static int __init test_user_copy_init(void)
"legitimate access_ok VERIFY_WRITE failed");
ret |= test(__copy_from_user(kmem, usermem, PAGE_SIZE),
"legitimate __copy_from_user failed");
+ ret |= test(__copy_from_user_inatomic(kmem, usermem, PAGE_SIZE),
+ "legitimate __copy_from_user_inatomic failed");
ret |= test(__copy_to_user(usermem, kmem, PAGE_SIZE),
"legitimate __copy_to_user failed");
+ ret |= test(__copy_to_user_inatomic(usermem, kmem, PAGE_SIZE),
+ "legitimate __copy_to_user_inatomic failed");
ret |= test(__copy_in_user(usermem, usermem + PAGE_SIZE, PAGE_SIZE),
"legitimate __copy_in_user failed");
ret |= test(__get_user(value, (unsigned long __user *)usermem),
@@ -137,12 +141,25 @@ static int __init test_user_copy_init(void)
ret |= test(!__copy_from_user(bad_usermem, (char __user *)kmem,
PAGE_SIZE),
"illegal reversed __copy_from_user passed");
+ ret |= test(!__copy_from_user_inatomic(kmem,
+ (char __user *)(kmem + PAGE_SIZE),
+ PAGE_SIZE),
+ "illegal all-kernel __copy_from_user_inatomic passed");
+ ret |= test(!__copy_from_user_inatomic(bad_usermem, (char __user *)kmem,
+ PAGE_SIZE),
+ "illegal reversed __copy_from_user_inatomic passed");
ret |= test(!__copy_to_user((char __user *)kmem, kmem + PAGE_SIZE,
PAGE_SIZE),
"illegal all-kernel __copy_to_user passed");
ret |= test(!__copy_to_user((char __user *)kmem, bad_usermem,
PAGE_SIZE),
"illegal reversed __copy_to_user passed");
+ ret |= test(!__copy_to_user_inatomic((char __user *)kmem,
+ kmem + PAGE_SIZE, PAGE_SIZE),
+ "illegal all-kernel __copy_to_user_inatomic passed");
+ ret |= test(!__copy_to_user_inatomic((char __user *)kmem, bad_usermem,
+ PAGE_SIZE),
+ "illegal reversed __copy_to_user_inatomic passed");
ret |= test(!__copy_in_user((char __user *)kmem,
(char __user *)(kmem + PAGE_SIZE),
PAGE_SIZE),
@@ -193,9 +210,16 @@ static int __init test_user_copy_init(void)
ret |= test(__copy_from_user(kmem, (char __user *)(kmem + PAGE_SIZE),
PAGE_SIZE),
"legitimate all-kernel __copy_from_user failed");
+ ret |= test(__copy_from_user_inatomic(kmem,
+ (char __user *)(kmem + PAGE_SIZE),
+ PAGE_SIZE),
+ "legitimate all-kernel __copy_from_user_inatomic failed");
ret |= test(__copy_to_user((char __user *)kmem, kmem + PAGE_SIZE,
PAGE_SIZE),
"legitimate all-kernel __copy_to_user failed");
+ ret |= test(__copy_to_user_inatomic((char __user *)kmem,
+ kmem + PAGE_SIZE, PAGE_SIZE),
+ "legitimate all-kernel __copy_to_user_inatomic failed");
ret |= test(__copy_in_user((char __user *)kmem,
(char __user *)(kmem + PAGE_SIZE),
PAGE_SIZE),
--
2.3.6
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
