On Thu, Sep 01, 2005 at 04:19:34PM +0200, Arjan van de Ven wrote: > > +/* Endian functions */ > > ehhhh again why?? > Why is this a compiletime hack? > Either you care about either-endian on disk, at which point it has to be > a runtime thing, or you make the on disk layout fixed endian, at which > point you really shouldn't abstract be16_to_cpu etc any further!
Again, on-disk is fixed little endian, so we have for example: #define gfs2_32_to_cpu le32_to_cpu #define cpu_to_gfs2_32 cpu_to_le32 To _test_ and _verify_ the endian-handling of the code we can #define GFS2_ENDIAN_BIG which switches the above to: #define gfs2_32_to_cpu to be32_to_cpu #define cpu_to_gfs2_32 to cpu_to_be32 We offered to removed this when I explained it before. It sounds like it would give you some comfort so I'll just go ahead and do it barring any pleas otherwise. Dave - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/