On Thu, Aug 6, 2015 at 1:22 PM, Laszlo Ersek <ler...@redhat.com> wrote: > On 08/06/15 14:12, Stefan Hajnoczi wrote: >> On Thu, Aug 6, 2015 at 12:03 PM, Marc Marí <mar...@redhat.com> wrote: >>> Add fw_cfg DMA interface specfication in the fw_cfg documentation. >>> >>> Signed-off-by: Marc Marí <mar...@redhat.com> >>> --- >>> Documentation/devicetree/bindings/arm/fw-cfg.txt | 36 >>> ++++++++++++++++++++++++ >>> 1 file changed, 36 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/arm/fw-cfg.txt >>> b/Documentation/devicetree/bindings/arm/fw-cfg.txt >>> index 953fb64..c880eec 100644 >>> --- a/Documentation/devicetree/bindings/arm/fw-cfg.txt >>> +++ b/Documentation/devicetree/bindings/arm/fw-cfg.txt >>> @@ -49,6 +49,41 @@ The guest kernel is not expected to use these registers >>> (although it is >> >> Please update the "=== Revision (Key 0x0001, FW_CFG_ID) ===" section >> to say that currently the revision is 2. > > Sorry I haven't started reading the series yet, but this caught my eye > -- can we agree that this field should be a bitmap instead, and not a > counter-like value? I don't insist of course, because for the current > use case both approaches will work. But, for "future proofing", I think > it is useful to express features independently of each other. (See eg. > virtio feature flags.)
Good idea. Stefan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
