2015-08-05 18:36+0200, Paolo Bonzini:
> On 05/08/2015 18:33, Radim Krčmář wrote:
>> +4.97 KVM_USER_EXIT
>> +
>> +Capability: KVM_CAP_USER_EXIT
>> +Architectures: x86
>> +Type: vcpu ioctl
>> +Parameters: struct kvm_user_exit (in)
>> +Returns: 0 on success,
>> + -EFAULT if the parameter couldn't be read,
>> + -EINVAL if 'reserved' is not zeroed,
>> +
>> +struct kvm_user_exit {
>> + __u8 reserved[32];
>> +};
>
> Can we just return EINVAL if the parameter is not NULL?
It complicates handling if we extend the ioctl, but removes the useless
clearing/copying/checking now ...
The two obvious extensions are flags to skip kvm_make_request() or
kvm_vcpu_kick(), both of dubious use. Another possibility is setting up
conditional exits, but that would be better as a separate control, like
most other sophisticated extensions.
I think that u32 flags would be sufficient -- is casting the 'unsigned
long arg' (data pointer) to a value still an accepted solution?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
