On Wed, Aug 12, 2015 at 02:41:22PM +0900, Namhyung Kim wrote: SNIP
> > > > Several lines are just comments explaining some tricks due to me not > > having found a counter for the number of colums somewhere and reusing > > the first loop that traverses them all to do the counting. > > > > There are two before those that at first I thought was needed, but ended > > up not using (would have to render the whole line in ui_browser to do > > the scrolling at line printing time, works only for browsers where just > > one call to ui_browser__printf or ui_browser__write_nstring is done, > > but I ended up leaving it there anyway, to try to make the > > hist_browser.c and other ui_browser implementations (annotate, etc) > > independent of libslang: > > > > $ git log --oneline | head -4 | tail -2 > > e7534e88dfa3 perf ui browser: Introduce ui_browser__printf() > > 2fe0f7e4b73e perf ui browser: Introduce ui_browser__write_nstring() > > $ > > > > Tested it with 'perf mem record -g -a' + 'perf mem report', and I liked > > how it works, please check if you like it too :-) > > > > The <- and -> keys are reused just when the horizontal scrolling mode is > > activate by setting ui_browser->columns, the hists_browser (perf report, > > perf top) will continue having ENTER and ESC, as always, to > > select/deselect things. > > Currently the help message in the hist browser says the arrows keys > are used to zoom in & out and ESC is for 'exit browser'. Do you think > it's ok to change the current behavior? I have some concern here as well.. but let's try and see ;-) but if we go this way I think I'd slighly prefer following behaviour: arrows : scroll by 1 column SHIFT-arrows : scroll by sort column but it's just a suggestion, I like your change as it is now as well thanks, jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/