On Wed, Aug 12, 2015 at 12:12:31PM +0200, Markus Pargmann wrote: > Cc: Stephen Boyd <[email protected]>
I'm not sure why you're putting this in these commit messages...
> if (!map->bus || map->use_single_rw) {
> + if (val_bytes != 1 && val_bytes != 2 && val_bytes != 4)
> + return -EINVAL;
> +
switch statement please. This also looks like a separate change to the
handling of single writes.
> + } else if (map->use_single_rw) {
> + /*
How are we ever going to fall into this else case? The first check has
an || map->use_single_rw it so if this is true then the first check will
be too so we'd never end up in this else case.
signature.asc
Description: Digital signature
