On 2015-08-12 16:53, Kris Borer wrote: > On Wed, Aug 12, 2015 at 10:12 AM, Michal Marek <[email protected] > <mailto:[email protected]>> wrote: > > On 2015-08-12 15:51, Kris Borer wrote: > > Add a semantic patch for fixing some cases of checkpatch.pl > <http://checkpatch.pl> error: > > > > ERROR: do not use assignment in if condition > > There is a gcc warning for this already. > > Michal > > > My intention was not to create another way to uncover problems but > rather to provide a tool for people to use to fix them. Let me know if > I am misunderstanding the purpose of this subsystem.
OK, so this is fixing a style issue, and not cases of accidental assignment instead of '==' (for which there is a gcc warning and we hopefully do not have such errors in the kernel). While I'm probably ignorant and no not see how one style is better than the other, I see that some maintainers already applied your patches based on this check. So I'll merge it once Julia acks it. P.S.: Please switch of HTML email, otherwise vger.kernel.org won't accept your messages. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
