On 08/13/2015 04:06 PM, Roger Quadros wrote: > Hi Chanwoo, > > On 13/08/15 03:29, Chanwoo Choi wrote: >> Commit b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions") >> changes the prototype of devm_gpiod_get_optional() API which should include >> the falgs mandatory. > > s/falgs/flags > >> >> Reported-by: Stephen Rothwell <s...@canb.auug.org.au> >> Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com> >> --- >> drivers/extcon/extcon-palmas.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c >> index 662e91778cb0..308928d44ead 100644 >> --- a/drivers/extcon/extcon-palmas.c >> +++ b/drivers/extcon/extcon-palmas.c >> @@ -208,7 +208,8 @@ static int palmas_usb_probe(struct platform_device *pdev) >> palmas_usb->wakeup = pdata->wakeup; >> } >> >> - palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id"); >> + palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id", >> + GPIOD_IN); >> if (IS_ERR(palmas_usb->id_gpiod)) { >> dev_err(&pdev->dev, "failed to get id gpio\n"); >> return PTR_ERR(palmas_usb->id_gpiod); >> > > Can you please include the following headers in this patch? > > #include <linux/gpio.h> > #include <linux/gpio/consumer.h>
I think that extcon-palmas need only "#include <linux/gpio/consumer.h>" because of of_gpio.h file already include the gpio.h. Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/