On Thu, Aug 13, 2015 at 09:46:00AM +0200, Peter Zijlstra wrote: > On Thu, Aug 13, 2015 at 02:55:55PM +0900, byungchul.p...@lge.com wrote: > > @@ -8023,16 +8036,7 @@ static void task_move_group_fair(struct task_struct > > *p, int queued) > > > > #ifdef CONFIG_SMP > > /* synchronize task with its prev cfs_rq */ > > - if (!queued) > > - __update_load_avg(cfs_rq->avg.last_update_time, > > cpu_of(rq_of(cfs_rq)), > > - &se->avg, se->on_rq * > > scale_load_down(se->load.weight), > > - cfs_rq->curr == se, NULL); > > - > > - /* remove our load when we leave */ > > - cfs_rq->avg.load_avg = max_t(long, cfs_rq->avg.load_avg - > > se->avg.load_avg, 0); > > - cfs_rq->avg.load_sum = max_t(s64, cfs_rq->avg.load_sum - > > se->avg.load_sum, 0); > > - cfs_rq->avg.util_avg = max_t(long, cfs_rq->avg.util_avg - > > se->avg.util_avg, 0); > > - cfs_rq->avg.util_sum = max_t(s32, cfs_rq->avg.util_sum - > > se->avg.util_sum, 0); > > + detach_entity_load_avg(cfs_rq, se); > > #endif > > set_task_rq(p, task_cpu(p)); > > se->depth = se->parent ? se->parent->depth + 1 : 0; > > @@ -8042,11 +8046,7 @@ static void task_move_group_fair(struct task_struct > > *p, int queued) > > > > #ifdef CONFIG_SMP > > /* Virtually synchronize task with its new cfs_rq */ > > - p->se.avg.last_update_time = cfs_rq->avg.last_update_time; > > - cfs_rq->avg.load_avg += p->se.avg.load_avg; > > - cfs_rq->avg.load_sum += p->se.avg.load_sum; > > - cfs_rq->avg.util_avg += p->se.avg.util_avg; > > - cfs_rq->avg.util_sum += p->se.avg.util_sum; > > + attach_entity_load_avg(cfs_rq, se); > > #endif > > } > > Can't we go one further and do: > > static void task_move_group_fair(struct task_struct *p) > { > struct rq *rq = task_rq(p); > > switched_from_fair(rq, p); > set_task_rq(p, task_cpu(p); > switched_to_fair(rq, p); > }
yeah, i think this is very nice idea which make code simple. i will try it. thanks, byungchul > > switched_from already does the vruntime and load_avg thing, > switched_to should do the reverse, although it currently doesn't appear > to put the load_avg back. > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/