On Thu, Aug 13, 2015 at 03:20:49PM -0400, Jérôme Glisse wrote: > +#if IS_ENABLED(CONFIG_INFINIBAND_ON_DEMAND_PAGING_HMM) > +#else /* CONFIG_INFINIBAND_ON_DEMAND_PAGING_HMM */
Yuk, what is wrong with #if !IS_ENABLED(...) ? > -#ifdef CONFIG_INFINIBAND_ON_DEMAND_PAGING > +#if IS_ENABLED(CONFIG_INFINIBAND_ON_DEMAND_PAGING) > +#if IS_ENABLED(CONFIG_INFINIBAND_ON_DEMAND_PAGING_HMM) > +#else /* CONFIG_INFINIBAND_ON_DEMAND_PAGING_HMM */ Double yuk #if !(IS_ENABLED(..) && IS_ENABLED(..)) ? And the #ifdefs suck, as many as possible should be normal if statements, and one should think carefully if we really need to remove fields from structures.. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
