On Mon, Aug 17, 2015 at 10:23 AM, Alexandre Courbot <acour...@nvidia.com> wrote:
> As reported by Alexey Khoroshilov: > > grgpio_irq_unmap() code looks quite suspicious regarding usage of > priv->bgc.lock spinlock. > > It locks the spinlock in line 310: > > spin_lock_irqsave(&priv->bgc.lock, flags); > > and then it can call grgpio_set_imask() in line 317: > > grgpio_set_imask(priv, i, 0); > > But grgpio_set_imask() unconditionally locks the spinlock by itself. > > Fix this by moving the spinlock acquisition outside of > grgpio_set_imask(). > > Found by Linux Driver Verification project (linuxtesting.org). > > Reported-by: Alexey Khoroshilov <khoroshi...@ispras.ru> > Signed-off-by: Alexandre Courbot <acour...@nvidia.com> > CC: Alexey Khoroshilov <khoroshi...@ispras.ru> > CC: Andreas Larsson <andr...@gaisler.com> Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
