On Tue 18 Aug 14:04 PDT 2015, Mathieu Olivari wrote:

> Add one new node to the ipq806x.dtsi file to declare & register the
> hardware spinlock devices. This mechanism is required to be used by
> other drivers such as SMEM.
> 

Still looks good, but you should have added:

Reviewed-by: Bjorn Andersson <[email protected]>
> Signed-off-by: Mathieu Olivari <[email protected]>
> ---
>  arch/arm/boot/dts/qcom-ipq8064.dtsi | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi 
> b/arch/arm/boot/dts/qcom-ipq8064.dtsi
> index 9f727d8..8d366ae 100644
> --- a/arch/arm/boot/dts/qcom-ipq8064.dtsi
> +++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi
> @@ -329,5 +329,16 @@
>                       #reset-cells = <1>;
>               };
>  
> +             sfpb_mutex_block: syscon@1200600 {
> +                     compatible = "syscon";
> +                     reg = <0x01200600 0x100>;
> +             };
> +     };
> +
> +     sfpb_mutex: sfpb-mutex {
> +             compatible = "qcom,sfpb-mutex";
> +             syscon = <&sfpb_mutex_block 4 4>;
> +
> +             #hwlock-cells = <1>;
>       };
>  };
> -- 
> 2.1.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to