Commit-ID:  e269ec42328783e51be08c191aa935dba56141fc
Gitweb:     http://git.kernel.org/tip/e269ec42328783e51be08c191aa935dba56141fc
Author:     Grygorii Strashko <grygorii.stras...@ti.com>
AuthorDate: Fri, 14 Aug 2015 15:20:27 +0300
Committer:  Thomas Gleixner <t...@linutronix.de>
CommitDate: Thu, 20 Aug 2015 00:25:25 +0200

irqchip/crossbar: Restore the irq_set_type() mechanism

The conversion of the crossbar irqchip to hierarchical irq domains
failed to provide a mechanism to properly set the trigger type of an
interrupt.

The crossbar irq chip itself has no mechanism and therefor no
irq_set_type() callback. The code before the conversion relayed the
trigger configuration directly to the underlying GIC.

Restore the correct behaviour by setting the crossbar irq_set_type
callback to irq_chip_set_type_parent(). This propagates the
set_trigger() call to the underlying GIC irqchip.

[ tglx: Massaged changelog ]

Fixes: 783d31863fb8 ('irqchip: crossbar: Convert dra7 crossbar...')
Signed-off-by: Grygorii Strashko <grygorii.stras...@ti.com>
Cc: Sudeep Holla <sudeep.ho...@arm.com>
Cc: <li...@arm.linux.org.uk>
Cc: <nsek...@ti.com>
Cc: <ja...@lakedaemon.net>
Cc: <ba...@ti.com>
Cc: <linux-arm-ker...@lists.infradead.org>
Cc: <t...@atomide.com>
Cc: <marc.zyng...@arm.com>
Cc: sta...@vger.kernel.org # 4.1
Link: 
http://lkml.kernel.org/r/1439554830-19502-4-git-send-email-grygorii.stras...@ti.com
Signed-off-by: Thomas Gleixner <t...@linutronix.de>
---
 drivers/irqchip/irq-crossbar.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c
index 692fe2b..3ba58e7 100644
--- a/drivers/irqchip/irq-crossbar.c
+++ b/drivers/irqchip/irq-crossbar.c
@@ -69,6 +69,7 @@ static struct irq_chip crossbar_chip = {
        .irq_unmask             = irq_chip_unmask_parent,
        .irq_retrigger          = irq_chip_retrigger_hierarchy,
        .irq_set_wake           = irq_chip_set_wake_parent,
+       .irq_set_type           = irq_chip_set_type_parent,
 #ifdef CONFIG_SMP
        .irq_set_affinity       = irq_chip_set_affinity_parent,
 #endif
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to