Hi Noam, On Friday 21 August 2015 04:05 PM, Noam Camus wrote: > From: Noam Camus <[email protected]> > > readl() for UCV and CPR will not work for port type UPIO_MEM32BE. > Instead we use the serial_in32() accessor which is initialized > properly according to endianness. > > Signed-off-by: Noam Camus <[email protected]> > --- > drivers/tty/serial/8250/8250_dw.c | 5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/tty/serial/8250/8250_dw.c > b/drivers/tty/serial/8250/8250_dw.c > index f479433..62f766a 100644 > --- a/drivers/tty/serial/8250/8250_dw.c > +++ b/drivers/tty/serial/8250/8250_dw.c > @@ -310,7 +310,8 @@ static bool dw8250_dma_filter(struct dma_chan *chan, void > *param) > static void dw8250_setup_port(struct uart_8250_port *up) > { > struct uart_port *p = &up->port; > - u32 reg = readl(p->membase + DW_UART_UCV); > + struct dw8250_data *d = p->private_data; > + u32 reg = d->serial_in(p->membase + DW_UART_UCV); > > /* > * If the Component Version Register returns zero, we know that > @@ -322,7 +323,7 @@ static void dw8250_setup_port(struct uart_8250_port *up) > dev_dbg_ratelimited(p->dev, "Designware UART version %c.%c%c\n", > (reg >> 24) & 0xff, (reg >> 16) & 0xff, (reg >> 8) & 0xff); > > - reg = readl(p->membase + DW_UART_CPR); > + reg = d->serial_in(p->membase + DW_UART_CPR); > if (!reg) > return; >
I think this can be folded into the previous patch - I don't see how this logically seperates anything from patch 1/2 -Vineet -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
