The Kconfig currently controlling compilation of this code is CONFIG_MMU which is per arch, but in all cases it is bool or def_bool meaning that it currently is not being built as a module by anyone.
Lets remove the couple traces of modularity so that when reading the code there is no doubt it is builtin-only. Since module_init translates to device_initcall in the non-modular case, the init ordering remains unchanged with this commit. However one could argue that subsys_initcall might make more sense here. Cc: Andrew Morton <[email protected]> Cc: Joonsoo Kim <[email protected]> Cc: Roman Pen <[email protected]> Cc: Andrey Ryabinin <[email protected]> Cc: Toshi Kani <[email protected]> Cc: David Rientjes <[email protected]> Cc: Rob Jones <[email protected]> Cc: WANG Chao <[email protected]> Cc: [email protected] Signed-off-by: Paul Gortmaker <[email protected]> --- mm/vmalloc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index 2faaa2976447..a27e6b3d58f4 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -10,7 +10,7 @@ #include <linux/vmalloc.h> #include <linux/mm.h> -#include <linux/module.h> +#include <linux/init.h> #include <linux/highmem.h> #include <linux/sched.h> #include <linux/slab.h> @@ -2686,7 +2686,7 @@ static int __init proc_vmalloc_init(void) proc_create("vmallocinfo", S_IRUSR, NULL, &proc_vmalloc_operations); return 0; } -module_init(proc_vmalloc_init); +device_initcall(proc_vmalloc_init); void get_vmalloc_info(struct vmalloc_info *vmi) { -- 2.5.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
