The Kconfig currently controlling compilation of this code is CONFIG_MMU
which is per arch, but in all cases it is bool or def_bool meaning that
it currently is not being built as a module by anyone.

Lets remove the couple traces of modularity so that when reading the
code there is no doubt it is builtin-only.

Since module_init translates to device_initcall in the non-modular
case, the init ordering remains unchanged with this commit.  However
one could argue that subsys_initcall might make more sense here.

Cc: Andrew Morton <a...@linux-foundation.org>
Cc: Joonsoo Kim <iamjoonsoo....@lge.com>
Cc: Roman Pen <r.peni...@gmail.com>
Cc: Andrey Ryabinin <a.ryabi...@samsung.com>
Cc: Toshi Kani <toshi.k...@hp.com>
Cc: David Rientjes <rient...@google.com>
Cc: Rob Jones <rob.jo...@codethink.co.uk>
Cc: WANG Chao <chaow...@redhat.com>
Cc: linux...@kvack.org
Signed-off-by: Paul Gortmaker <paul.gortma...@windriver.com>
---
 mm/vmalloc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index 2faaa2976447..a27e6b3d58f4 100644
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -10,7 +10,7 @@
 
 #include <linux/vmalloc.h>
 #include <linux/mm.h>
-#include <linux/module.h>
+#include <linux/init.h>
 #include <linux/highmem.h>
 #include <linux/sched.h>
 #include <linux/slab.h>
@@ -2686,7 +2686,7 @@ static int __init proc_vmalloc_init(void)
        proc_create("vmallocinfo", S_IRUSR, NULL, &proc_vmalloc_operations);
        return 0;
 }
-module_init(proc_vmalloc_init);
+device_initcall(proc_vmalloc_init);
 
 void get_vmalloc_info(struct vmalloc_info *vmi)
 {
-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to