Hi Stephen, On Wed, Aug 26, 2015 at 12:46 AM, Stephen Boyd <sb...@codeaurora.org> wrote: >> --- /dev/null >> +++ b/drivers/clk/shmobile/clk-rcar-gen3.c
>> + >> +/* >> + * Reset register definitions. >> + */ >> +#define MODEMR 0xe6160060 >> + >> +static u32 rcar_gen3_read_mode_pins(void) >> +{ >> + static u32 mode; >> + static bool mode_valid; >> + >> + if (!mode_valid) { >> + void __iomem *modemr = ioremap_nocache(MODEMR, 4); >> + >> + BUG_ON(!modemr); >> + mode = ioread32(modemr); >> + iounmap(modemr); >> + mode_valid = true; >> + } >> + >> + return mode; >> +} > > Perhaps this should be read using a syscon? Like "[PATCH/RFC 00/11] ARM: shmobile: Let CPG use syscon for MD pin values" (http://www.spinics.net/lists/linux-clk/msg01478.html)? It wasn't so well received... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/