On Tue, Aug 25, 2015 at 01:12:02PM -0700, Dave Hansen wrote:
>
> From: Dave Hansen <dave.han...@linux.intel.com>
>
> The 'xfeature_bit's are at best xfeature bit _numbers_. Calling
> them bits is at best inconsistent with ending the enum list with
> 'XFEATURES_NR_MAX'.
>
> This patch renames the enum to be 'xfeature_nr'. These also
> happen to be what the Intel documentation calls a "state
> component".
>
> Signed-off-by: Dave Hansen <dave.han...@linux.intel.com>
> Cc: Ingo Molnar <mi...@redhat.com>
> Cc: x...@kernel.org
> Cc: Borislav Petkov <b...@alien8.de>
> Cc: Fenghua Yu <fenghua...@intel.com>
> Cc: Tim Chen <tim.c.c...@linux.intel.com>
> Cc: linux-kernel@vger.kernel.org
> ---
>
> b/arch/x86/include/asm/fpu/types.h | 38
> ++++++++++++++++++++-----------------
> 1 file changed, 21 insertions(+), 17 deletions(-)
>
> diff -puN arch/x86/include/asm/fpu/types.h~x86-fpu-rename-xfeature_bit
> arch/x86/include/asm/fpu/types.h
> --- a/arch/x86/include/asm/fpu/types.h~x86-fpu-rename-xfeature_bit
> 2015-08-25 12:49:58.393504548 -0700
> +++ b/arch/x86/include/asm/fpu/types.h 2015-08-25 12:49:58.396504684
> -0700
> @@ -95,27 +95,31 @@ struct swregs_state {
> /*
> * List of XSAVE features Linux knows about:
> */
> -enum xfeature_bit {
> - XSTATE_BIT_FP,
> - XSTATE_BIT_SSE,
> - XSTATE_BIT_YMM,
> - XSTATE_BIT_BNDREGS,
> - XSTATE_BIT_BNDCSR,
> - XSTATE_BIT_OPMASK,
> - XSTATE_BIT_ZMM_Hi256,
> - XSTATE_BIT_Hi16_ZMM,
> +enum xfeature_nr {
> + XFEATURE_NR_FP,
> + XFEATURE_NR_SSE,
> + /*
> + * Values above here are "legacy states".
> + * Those below are "extended states".
> + */
> + XFEATURE_NR_YMM,
> + XFEATURE_NR_BNDREGS,
> + XFEATURE_NR_BNDCSR,
> + XFEATURE_NR_OPMASK,
> + XFEATURE_NR_ZMM_Hi256,
> + XFEATURE_NR_Hi16_ZMM,
Why not simply
s/NR_//
?
I.e., XFEATURE_FP, XFEATURE_SSE and so on...
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
