On Wed, 26 Aug, at 03:46:51PM, Jiri Olsa wrote: > Pass 'struct parse_events_error *error' to the parse-event.c > tracepoint adding path. It will be filled with error data > in following patches. > > Link: http://lkml.kernel.org/n/[email protected] > Signed-off-by: Jiri Olsa <[email protected]> > --- > tools/perf/util/parse-events.c | 27 ++++++++++++++++----------- > tools/perf/util/parse-events.h | 3 ++- > tools/perf/util/parse-events.y | 4 ++-- > 3 files changed, 20 insertions(+), 14 deletions(-)
Is there a reason you decided to go ahead with passing 'data->error' directly to the parsing functions instead of adding some global state for recording errors, like a globally accessible 'parse_events_error'? Because I notice that if someone wanted to improve the breakpoint parsing code, they'd basically need to make the same changes you've made in this patch. -- Matt Fleming, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
