On Mon, Aug 31, 2015 at 10:38:21AM +0200, Peter Zijlstra wrote: > Looking at the BKDG Fam 15h 60h-6Fh these MSRs are per compute unit. > This means you can do much finer grained measurements than system wide
Well, we can do finer-grained if needed. I'm all for everything which has a good use case. The use case we had in mind here was the physical processor power consumption for a time period. > -- which is all hwmon seems capable of. I guess we can do both - perf and hwmon. I don't see why not. > Not to mention the proposed code is horrible, who in their right mind > does two rdmsrl_safe_on_cpu() back to back. That's a good point - I missed that during previous review. Rui, please put the rdmsrl_safe_on_cpu() accesses in a separate function which you run on a particular CPU, for your next version. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/