Am Mittwoch, den 02.09.2015, 14:36 +0530 schrieb Viresh Kumar: > Tolerance applies on both sides of the target voltage, i.e. both min and > max sides.
While I'm not really comfortable with the above, it is exactly how OPPv1 and the voltage tolerance property are specified. Reviewed-by: Lucas Stach <[email protected]> > But while checking if a voltage is supported by the regulator > or not, we haven't taken care of tolerance on the lower side. Fix that. > > Cc: Lucas Stach <[email protected]> > Fixes: 045ee45c4ff2 ("cpufreq: cpufreq-dt: disable unsupported OPPs") > Signed-off-by: Viresh Kumar <[email protected]> > --- > drivers/cpufreq/cpufreq-dt.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/cpufreq-dt.c b/drivers/cpufreq/cpufreq-dt.c > index b1131cf89757..3b64c203bf99 100644 > --- a/drivers/cpufreq/cpufreq-dt.c > +++ b/drivers/cpufreq/cpufreq-dt.c > @@ -303,7 +303,8 @@ static int cpufreq_init(struct cpufreq_policy *policy) > rcu_read_unlock(); > > tol_uV = opp_uV * priv->voltage_tolerance / 100; > - if (regulator_is_supported_voltage(cpu_reg, opp_uV, > + if (regulator_is_supported_voltage(cpu_reg, > + opp_uV - tol_uV, > opp_uV + tol_uV)) { > if (opp_uV < min_uV) > min_uV = opp_uV; -- Pengutronix e.K. | Lucas Stach | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
