On 02/09/15 11:19, Jan Stancek wrote: > Add -z parameter to avoid skipping zero blocks: > > ffffffff816704fe <sysret_check+0x4b>: > ffffffff816704fe: 7b 34 jnp ffffffff81670534 <sysret_signal+0x1c> > ... > ffffffff81670501 <sysret_careful>: > ffffffff81670501: 0f ba e2 03 bt $0x3,%edx > ffffffff81670505: 73 11 jae ffffffff81670518 <sysret_signal> > > Signed-off-by: Jan Stancek <jstan...@redhat.com> > Cc: Arnaldo Carvalho de Melo <a...@kernel.org> > Cc: Jiri Olsa <jo...@kernel.org> > Cc: Adrian Hunter <adrian.hun...@intel.com> > Cc: David Ahern <dsah...@gmail.com> > Cc: Corey Ashford <cjash...@linux.vnet.ibm.com> > Cc: Frederic Weisbecker <fweis...@gmail.com> > Cc: Ingo Molnar <mi...@kernel.org> > Cc: Namhyung Kim <namhy...@kernel.org> > Cc: Paul Mackerras <pau...@samba.org> > Cc: Peter Zijlstra <a.p.zijls...@chello.nl>
Apart from nitpick below: Acked-by: Adrian Hunter <adrian.hun...@intel.com> > --- > tools/perf/tests/code-reading.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tools/perf/tests/code-reading.c b/tools/perf/tests/code-reading.c > index 38ee90bc2228..375ba30e4ed0 100644 > --- a/tools/perf/tests/code-reading.c > +++ b/tools/perf/tests/code-reading.c > @@ -128,7 +128,8 @@ static int read_via_objdump(const char *filename, u64 > addr, void *buf, > FILE *f; > int ret; > > - fmt = "%s -d --start-address=0x%"PRIx64" --stop-address=0x%"PRIx64" %s"; > + fmt = "%s -z -d --start-address=0x%"PRIx64\ The line continuation is not needed but we are not that religious about long lines especially if they contain string literals, so you could just make it one line. > + " --stop-address=0x%"PRIx64" %s"; > ret = snprintf(cmd, sizeof(cmd), fmt, "objdump", addr, addr + len, > filename); > if (ret <= 0 || (size_t)ret >= sizeof(cmd)) > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
