On Thu, Sep 03, 2015 at 12:41:47PM +0200, Thomas Gleixner wrote:
> On Thu, 3 Sep 2015, Borislav Petkov wrote:
> > On Wed, Sep 02, 2015 at 11:11:55AM +0200, Thomas Gleixner wrote:
> > > static void __init_or_module add_nops(void *insns, unsigned int len)
> > > {
> > > + unsigned long flags;
> > > +
> > > + local_irq_save(flags);
> > > while (len > 0) {
> >
> > I guess you want to optimize the len==0 case to not disable interrupts
> > needlessly:
> >
> > if (!len)
> > return;
> >
> > local_irq_save(flags);
> > while (len > 0)
> > ...
>
> Nah. I rather put the local_irq_save into optimize_nops(). All other
> callers of add_nops() are operating on a buffer and use text_poke
> after that. Aside of that optimize_nops() is missing a sync_core().
>
> Updated patch below.
V2 of the patch managed ~ 5000 iterations overnight without hitting
the problem, so looks like it's a good fix.
Thanks, Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines. Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
