On Mon, Sep 07, 2015 at 04:01:22PM +0200, David Sterba wrote:
> So, updated patches should mention that in the subject eg:
>
> [PATCH v2] btrfs: memset cur_trans->delayed_refs to zero
>
> On Mon, Sep 07, 2015 at 04:45:02PM +0300, Alexandru Moise wrote:
> > Use memset() to null out the btrfs_delayed_ref_root of
> > btrfs_transaction instead of setting all the members to 0 by hand.
> >
> > Signed-off-by: Alexandru Moise <00moses.alexande...@gmail.com>
> > ---
>
> And in this section (ie. after the first ---) put a brief description of
> the changes.
Will do.
>
> > fs/btrfs/transaction.c | 12 ++++++------
> > 1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/fs/btrfs/transaction.c b/fs/btrfs/transaction.c
> > index 8f259b3..0581fb4 100644
> > --- a/fs/btrfs/transaction.c
> > +++ b/fs/btrfs/transaction.c
> > @@ -224,15 +224,15 @@ loop:
> > cur_trans->start_time = get_seconds();
> > cur_trans->dirty_bg_run = 0;
> >
> > + memset(&cur_trans->delayed_refs, 0, sizeof(cur_trans->delayed_refs));
> > +
> > + /*
> > + * For now RB_ROOT means set to NULL but this could change in
> > + * the future
> > + */
>
> I don't think such comment necessary, the code is clear enough without
> it.
>
> > cur_trans->delayed_refs.href_root = RB_ROOT;
> > cur_trans->delayed_refs.dirty_extent_root = RB_ROOT;
>
> .
Alright I can agree to that, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
