* Vitaly Kuznetsov <[email protected]> wrote:
> Stephen Hemminger <[email protected]> writes:
>
> > Fixes regression 4.3 mergw window in my config
> > where hyperv is enable but CONFIG_KEXEC not enabled.
> >
> > arch/x86/kernel/cpu/mshyperv.c:112: undefined reference to
> > `native_machine_crash_shutdown'
> >
> > Introduced by:
> > commit b4370df2b1f5158de028e167974263c5757b34a6
> > Author: Vitaly Kuznetsov <[email protected]>
> > Date: Sat Aug 1 16:08:09 2015 -0700
> >
> > Drivers: hv: vmbus: add special crash handler
> >
> > Signed-off-by: Stephen Hemminger <[email protected]>
> >
> > --- a/arch/x86/kernel/cpu/mshyperv.c 2015-09-07 10:11:24.994885115
> > -0700
> > +++ b/arch/x86/kernel/cpu/mshyperv.c 2015-09-07 10:14:20.995698615
> > -0700
> > @@ -109,7 +109,9 @@ static void hv_machine_crash_shutdown(st
> > {
> > if (hv_crash_handler)
> > hv_crash_handler(regs);
> > +#ifdef CONFIG_KEXEC
> > native_machine_crash_shutdown(regs);
> > +#endif
> > }
>
> Greg in particular was against #ifdefs in C code and I sent the
> following patch to fix the issue:
>
> https://lkml.org/lkml/2015/8/11/417
Note that this is still somewhat buggy, the whole hv_machine_crash_shutdown()
should be conditional - like in kvmclock.c.
Thanks,
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/