On Thu, Sep 08, 2005 at 01:13:58PM -0700, David S. Miller wrote: > From: Linus Torvalds <[EMAIL PROTECTED]> > Date: Thu, 8 Sep 2005 09:27:56 -0700 (PDT) > > > Mistakes happen, and the way you fix them is not to pull a tantrum, but > > tell people that they are idiots and they broke something, and get them to > > fix it instead. > > In all this noise I still haven't seen what is wrong with > the build warning fix I made.
The fact that it's called regardless of SUPPORT_SYSRQ and some callers look like #ifdef SUPPORT_SYSRQ int foo(blah, struct pt_regs *regs) #else int foo(blah) #endif { ... uart_handle_sysrq_char(..., regs); ... } which works with old definition (without SUPPORT_SYSRQ the last argument of uart_handle_sysrq_char() is never seen by parser) and obviously dies with the new one. And yes, it's sick... - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/