Commit-ID:  a69b09e2342a9c144b0291b9aeb849ab7d5843bf
Gitweb:     http://git.kernel.org/tip/a69b09e2342a9c144b0291b9aeb849ab7d5843bf
Author:     Adrian Hunter <[email protected]>
AuthorDate: Tue, 8 Sep 2015 10:58:49 +0300
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Tue, 15 Sep 2015 10:08:22 -0300

perf evlist: Simplify propagate_maps() logic

If evsel->cpus is to be reassigned then the current value must be "put",
which works even if it is NULL.  Simplify the current logic by moving
the "put" next to the assignment.

Signed-off-by: Adrian Hunter <[email protected]>
Acked-by: Jiri Olsa <[email protected]>
Cc: Kan Liang <[email protected]>
Link: 
http://lkml.kernel.org/r/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
---
 tools/perf/util/evlist.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c
index d51a520..95e07ea 100644
--- a/tools/perf/util/evlist.c
+++ b/tools/perf/util/evlist.c
@@ -1113,11 +1113,10 @@ static int perf_evlist__propagate_maps(struct 
perf_evlist *evlist,
                 * We already have cpus for evsel (via PMU sysfs) so
                 * keep it, if there's no target cpu list defined.
                 */
-               if (evsel->cpus && has_user_cpus)
+               if (!evsel->cpus || has_user_cpus) {
                        cpu_map__put(evsel->cpus);
-
-               if (!evsel->cpus || has_user_cpus)
                        evsel->cpus = cpu_map__get(evlist->cpus);
+               }
 
                evsel->threads = thread_map__get(evlist->threads);
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to