On Mon, Oct 31, 2005 at 01:14:22PM -0800, Matt Mackall wrote: > On Mon, Oct 31, 2005 at 10:05:15PM +0100, Geert Uytterhoeven wrote: > > On Mon, 31 Oct 2005, Matt Mackall wrote: > > > inflate: remove legacy type definitions from callers > > > > > > This replaces the legacy zlib typedefs and usage with kernel types in > > > all the inflate users. > > > > > -static ulg free_mem_ptr; > > > -static ulg free_mem_ptr_end; > > > +static u32 free_mem_ptr; > > > +static u32 free_mem_ptr_end; > > > > Bang, on 64-bit platforms... > > That was quick. > > Yes, this is broken on Alpha. The other 64-bit arches use proper pointers > here. But I need to change all the arches to use the same pointer > type, probably as patch 8.5 in the series.
But if it's a pointer why don't you declare them unsigned long then ? C defines the long as the integer the right size to store a pointer. u32 is just a 32 bits unsigned integer, which will not always do what you're looking for. Having read the rest of the patch, I guess you can also make the pointer (void *) and avoid a few casts later. Regards, Willy
