On Thu, Nov 16, 2006 at 11:03:07AM +1100, Michael Ellerman wrote: > On Wed, 2006-11-15 at 15:26 -0600, Linas Vepstas wrote: > > > > This is a non-urgent patch. > > > > I can't figure out who the upstream maintainer for char drivers > > is supposed to be. Can this patch be applied? > > > > --linas > > > > This patch removes an pair of irritating compiler warnings: > > > > drivers/char/hvcs.c:1605: warning: ignoring return value of > > sysfs_create_group declared with attribute warn_unused_result > > drivers/char/hvcs.c:1639: warning: ignoring return value of > > driver_create_file declared with attribute warn_unused_result > > > > Doing this required moving a big block of code from the bottom > > of the file to the top, so as to avoid the need for (irritating) > > forward declarations. > > Can you do the move and the fix as two patches? It's very hard to review > in its current form.
Sorry, coming shortly. -- linas - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/