Hi, On Tue, Aug 25, 2015 at 03:07:07PM +0900, Milo Kim wrote: > Currently, lp8727 charger driver parses the DT and copies values into the > 'cl->dev.platform_data' if 'of_node' exists. > This may have architectural issue. Platform data is configurable through > the DT or I2C board info inside the platform area. > However, lp8727 driver changes this configuration when it is loaded. > > The driver should get data from the platform side and use the private > data, 'lp8727_chg->pdata' instead of changing the original platform data. > > _probe() procedure is changed as follows. > 1. lp8727_parse_dt() returns the pointer of lp8727_platform_data. > The driver uses this allocated platform data. So it should keep > original platform data, 'dev->platform_data'. > 2. In _probe(), check the return value of lp8727_parse_dt(). > If an error is found, then exit as PTR_ERR(pdata). > 3. If 'of_node' is not found, then the driver just gets the platform data > from the I2C device structure. > 4. Map the platform data to private data structure.
Thanks, I queued both patches. -- Sebastian
signature.asc
Description: Digital signature
