On Fri, Sep 25, 2015 at 09:26:21AM +0100, Felipe Tonello wrote: > Hi Peter, > > On Thu, Sep 24, 2015 at 2:17 AM, Peter Chen <peter.c...@freescale.com> wrote: > > On Wed, Sep 23, 2015 at 12:56:58PM +0100, Felipe F. Tonello wrote: > >> If CONFIG_PM or CONFIG_PM_SLEEP is not set, driver will not compile > >> properly. > >> > > > > Would you post the warning or error messages? > > > > I just tried at v4.3-rc1 (v4.2 should be same), without any problems. > > Actually I tested again with the latest and it doesn't break. But > still I believe it is the right thing to do, even though it builds. > Just good practice to make sure the ifdefs are correct on driver code. >
We need to decrease #ifdefs as less as possible, only add it if it really needs. -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
