On Sat, Nov 18, 2006 at 09:49:14AM +0100, Andi Kleen wrote: > On Friday 17 November 2006 23:37, Vivek Goyal wrote: > > > > This patch makes pgtable.h and page.h safe to include > > in assembly files like head.S. Allowing us to use > > symbolic constants instead of hard coded numbers when > > refering to the page tables. > > I still think that macro is horrible ugly and the use of that > macro should be minimized as suggested earlier. > Hi Andi,
Personally I think maintenance is easier if we don't try to discriminate between the constants which require that macro and which don't require. But if you don't like it, then its ok, I will only apply it to places where it is really required and breaks the things (like shift operations). Will do that change in next posting. Thanks Vivek - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
